ansible-scylla-node: Improves "legacy" support for 'node-exporter'#253
Open
ebenzecri wants to merge 1 commit intoscylladb:masterfrom
Open
ansible-scylla-node: Improves "legacy" support for 'node-exporter'#253ebenzecri wants to merge 1 commit intoscylladb:masterfrom
ebenzecri wants to merge 1 commit intoscylladb:masterfrom
Conversation
4543d96 to
c4c2fb0
Compare
This patch improves how 'node_exporter_install' is called and how 'node-exporter' service is started. Fixes: scylladb#249 Signed-off-by: Eduardo Benzecri <eduardo.benzecri@scylladb.com>
Contributor
Author
Installing Scylla Enterprise 2021 from scratch
Installing Scylla Enterprise 2022 from scratch
Upgrading Scylla Enterprise from 2021 to 2022Here I've spotted a problem related to systemd units. After upgrading 2022.2, the unit file corresponding to So, if I run The solution here seems to be calling a handler for reloading systemd configuration (there's an unused one there), but probably Molecule will fail (because Scylla images aren't using systemd). All handlers that manages systemd unit must be skipped from testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch improves how 'node_exporter_install' is called and how 'node-exporter' service is started.
Fixes: #249